Updates from helgatheviking Toggle Comment Threads | Keyboard Shortcuts

  • helgatheviking 8:09 pm on June 15, 2012 Permalink
    Tags: comments   

    Opinions on THEMATIC_COMPATIBLE_COMMENT_FORM and THEMATIC_COMPATIBLE_COMMENT_FORM 

    i’m trying to figure out what exactly these are doing. what do we want to do with them in the future?

     
  • helgatheviking 4:11 am on June 12, 2012 Permalink
    Tags: theme review, wordpress 3.4   

    Here's what i see for wp 3.4… 

    so here’s what i see for wp 3.4:

    • previous_image_link()/next_image_link() (or equivalent) – don’t know what this is exactly
    • should we add background and header image support ?
    • modify wp_title via filter *karin did this on our fork, so the code is out there
    • body_class()/post_class(): – i thought i had patched this at google code. maybe we just go ahead add the classes instead of needing an add_theme_support() for legacy? though i like the idea of completely deprecating the thematic versions of those functions
    • remove/deprecate constants
    • enqueue the comment-reply script at the comment_form_before hook
    • updated translations
    • gene’s markup function

    oh i also see that

    $locale_file = THEMELIB . "/languages/$locale.php";
    if ( is_readable($locale_file) )
    require_once ($locale_file);

    can probably be removed.. in addition, we can probably remove

    /**

    • Legacy options global variables likely not needed anymore…
    • Can these be removed safely?

    */
    $themename = "Thematic";
    $shortname = "thm";


    anything else? not sure we’d want to tackle more than that.

    btw- in case i can get to it (unlikely though, paid job and father’s day will keep me busy this week) what is the proper way to let users know a function is deprecated?

     
c
Compose new post
j
Next post/Next comment
k
Previous post/Previous comment
r
Reply
e
Edit
o
Show/Hide comments
t
Go to top
l
Go to login
h
Show/Hide help
shift + esc
Cancel